Api and Management support minio #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nataly87s
force-pushed
the
613_object_storage
branch
from
67e1f09
to
ce484af
Compare
Yshayy
reviewed
Nov 5, 2017
CI/test-composition.yml
Outdated
| depends_on: | ||
| - minio | ||
| - redis | ||
| - management |
There was a problem hiding this comment.
api doesn't need to depend on management if using minio
Yshayy
reviewed
Nov 5, 2017
| private readonly IDisposable _subscription; | ||
| private readonly IConnectableObservable<Dictionary<string, RuleDefinition>> _pipeline; | ||
|
|
||
| public MinioRulesDriver(IMinioClient minioClient, MinioRulesDriverSettings settings, ILogger logger = null, IScheduler scheduler = null) |
Yshayy
suggested changes
Nov 5, 2017
| }); | ||
| } | ||
|
|
||
| async function cleanStorage(allowed) { |
There was a problem hiding this comment.
maybe change "allowed" to "exclude"
Yshayy
reviewed
Nov 5, 2017
There was a problem hiding this comment.
Hmm, why the rules diagnostics provider is an addon?
Additionally, since the diagnostics provider is no longer tied to implementation detail, it can be moved to tweek api, like https://github.com/Soluto/tweek/blob/master/services/api/Tweek.ApiService.NetCore/Metrics/TimedContextDriver.cs
Every new .net project can add some overhead in terms of build time and maintenance.
|
We should also bump api major version since it's a breaking change. |
Yshayy
approved these changes
Nov 5, 2017
|
Looks good! |
|
Codefresh failures look real |
nataly87s
force-pushed
the
613_object_storage
branch
from
876ca06
to
ec9d7ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #613