Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update should just add any local defined tags, not replace #212

Closed
KivraChristoffer opened this issue Mar 20, 2022 · 1 comment
Closed

update should just add any local defined tags, not replace #212

KivraChristoffer opened this issue Mar 20, 2022 · 1 comment

Comments

@KivraChristoffer
Copy link
Contributor

So if the agent have a definition of tags defines it will remove any other tags on the host.
Would good if there would be a option to change the behavior so it will make sure the tags in the file are present and not remove any other tags.
@cyrinux
Copy link
Collaborator

cyrinux commented Mar 28, 2022 •
edited
Loading

Hi, thanks for your report, I will study this :)

cyrinux added a commit to cyrinux/netbox-agent that referenced this issue Mar 28, 2022
@cyrinux
fix(Solvik#212): prevent server tags to be override.
8a9891a 
Add a param `--replace-tags` to override all tags, default behavior is to append new tags.
cyrinux added a commit to cyrinux/netbox-agent that referenced this issue Mar 28, 2022
@cyrinux
fix(Solvik#212): prevent server tags to be override.
e4a7237 
Add a param `--replace-tags` to override all tags, default behavior is to append new tags.
cyrinux added a commit to cyrinux/netbox-agent that referenced this issue Mar 28, 2022
@cyrinux
fix(Solvik#212): prevent server tags to be override.
c99f23e 
Add a param `--replace-tags` to override all tags, default behavior is to append new tags.
cyrinux added a commit to cyrinux/netbox-agent that referenced this issue Mar 28, 2022
@cyrinux
fix(Solvik#212): prevent server tags to be override.
dd4d935 
Add a param `--replace-tags` to override all tags, default behavior is to append new tags.
cyrinux added a commit that referenced this issue Mar 28, 2022
@cyrinux
Merge pull request #213 from cyrinux/feat/add_tags_replace_params
7bf955d 
fix(#212): prevent server tags to be override by default
@cyrinux cyrinux closed this as completed Mar 28, 2022
devopstales pushed a commit to devopstales/netbox-agent2 that referenced this issue Jun 24, 2022
@cyrinux
fix(Solvik#212): prevent server tags to be override.
adb4ad0 
Add a param `--replace-tags` to override all tags, default behavior is to append new tags.
devopstales pushed a commit to devopstales/netbox-agent2 that referenced this issue Jun 24, 2022
@cyrinux
Merge pull request Solvik#213 from cyrinux/feat/add_tags_replace_params
fc0ce36 
fix(Solvik#212): prevent server tags to be override by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cyrinux @KivraChristoffer