Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added platform to the config with auto-detect as fallback #216

Merged
merged 7 commits into from
Apr 1, 2022

Conversation

cyrinux
Copy link
Collaborator

@cyrinux cyrinux commented Mar 31, 2022

#215 with auto detect device platform / os added

@cyrinux cyrinux changed the title Feature/platform Added platform to the config with auto-detect as fallback Mar 31, 2022
@cyrinux
Copy link
Collaborator Author

cyrinux commented Mar 31, 2022

superseed #215

this platform module still works for python3.6 we use.

Signed-off-by: Cyril Levis <git@levis.name>
@KivraChristoffer
Copy link
Contributor

KivraChristoffer commented Mar 31, 2022

@cyrinux , works, but with no config, it would not autodetect, but it will not remove a value if its defined and there is no config.
So during my test all works but not the autodetect.

( tested on centos 8.2 )

@cyrinux
Copy link
Collaborator Author

cyrinux commented Mar 31, 2022

Thanks for the test, will try on my side, what python version are you using ?

@KivraChristoffer
Copy link
Contributor

@cyrinux
python --version Python 3.6.8 (virtend-netbox

Signed-off-by: Cyril Levis <git@levis.name>
@cyrinux
Copy link
Collaborator Author

cyrinux commented Mar 31, 2022

@KivraChristoffer I forgot to remove a condition, it should be ok with this last fix, I test on my side and its good.

@KivraChristoffer
Copy link
Contributor

KivraChristoffer commented Mar 31, 2022 via email

@cyrinux
Copy link
Collaborator Author

cyrinux commented Mar 31, 2022

Would you like me to do the tests again ? Den tors 31 mars 2022 19:55Cyril Levis @.> skrev:

@KivraChristoffer https://github.com/KivraChristoffer I forgot to remove a condition, it should be ok with this last fix, I test on my side and its good. — Reply to this email directly, view it on GitHub <#216 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR6PJMRSZA6FT3ML7VV6QU3VCXRJ7ANCNFSM5SFWSXIA . You are receiving this because you were mentioned.Message ID: @.
>

Yes please ;-)

Signed-off-by: Cyril Levis <git@levis.name>
Signed-off-by: Cyril Levis <git@levis.name>
Signed-off-by: Cyril Levis <git@levis.name>
@KivraChristoffer
Copy link
Contributor

Would you like me to do the tests again ? Den tors 31 mars 2022 19:55Cyril Levis @.> skrev:

@KivraChristoffer https://github.com/KivraChristoffer I forgot to remove a condition, it should be ok with this last fix, I test on my side and its good. — Reply to this email directly, view it on GitHub <#216 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR6PJMRSZA6FT3ML7VV6QU3VCXRJ7ANCNFSM5SFWSXIA . You are receiving this because you were mentioned.Message ID: _
@**
.**_>

Yes please ;-)

allt worked good,
automated found this:

CentOS Linux 8.2.2004 Core

CentOS Linux 8.2.2004 Core

@cyrinux
Copy link
Collaborator Author

cyrinux commented Apr 1, 2022

Thanks, I will merge this and try to do a release soon.
Bug reports and new features appreciate 😺

@cyrinux cyrinux merged commit d069318 into Solvik:master Apr 1, 2022
@KivraChristoffer
Copy link
Contributor

Thanks, I will merge this and try to do a release soon. Bug reports and new features appreciate smiley_cat

We have 2 others comming.
1 where is a raidcard dont have any disks attached.
2 report in diskspace ( mainly vm's )

@cyrinux cyrinux deleted the feature/platform branch April 1, 2022 07:30
devopstales pushed a commit to devopstales/netbox-agent2 that referenced this pull request Jun 24, 2022
Added platform to the config with auto-detect as fallback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants