-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added platform to the config with auto-detect as fallback #216
Conversation
superseed #215 |
this platform module still works for python3.6 we use. Signed-off-by: Cyril Levis <git@levis.name>
1e3a97a
to
cf2cc54
Compare
@cyrinux , works, but with no config, it would not autodetect, but it will not remove a value if its defined and there is no config. ( tested on centos 8.2 ) |
Thanks for the test, will try on my side, what python version are you using ? |
@cyrinux |
Signed-off-by: Cyril Levis <git@levis.name>
@KivraChristoffer I forgot to remove a condition, it should be ok with this last fix, I test on my side and its good. |
Would you like me to do the tests again ?
Den tors 31 mars 2022 19:55Cyril Levis ***@***.***> skrev:
… @KivraChristoffer <https://github.com/KivraChristoffer> I forgot to
remove a condition, it should be ok with this last fix, I test on my side
and its good.
—
Reply to this email directly, view it on GitHub
<#216 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AR6PJMRSZA6FT3ML7VV6QU3VCXRJ7ANCNFSM5SFWSXIA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Yes please ;-) |
Signed-off-by: Cyril Levis <git@levis.name>
c2bdae8
to
dfb6b23
Compare
Signed-off-by: Cyril Levis <git@levis.name>
Signed-off-by: Cyril Levis <git@levis.name>
allt worked good, CentOS Linux 8.2.2004 Core |
Thanks, I will merge this and try to do a release soon. |
We have 2 others comming. |
Added platform to the config with auto-detect as fallback
#215 with auto detect device platform / os added