Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flask-Cors py2 dependence #7

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Conversation

anxodio
Copy link

@anxodio anxodio commented Oct 4, 2023

Heman en python 2 (entenc que el que hi ha a producció) no te el paquet Flask-Cors fixat al requirements.txt, i desde el 26 de juny ha sortit la versió 4.0.0 que es descarrega però que no es compatible amb Python2 i peta en execució (deuen tenir-ho mal configurat)

Aquest PR arregla això :)

@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vokimon vokimon merged commit bd3c0b6 into master Oct 5, 2023
4 of 6 checks passed
@vokimon
Copy link
Member

vokimon commented Oct 5, 2023

@anxodio thanks por the PR. I integrated it since the incompatibility and pinning are correct. But, do yo need a release, and/or deploy? Which is the use you are doing of it? (i guess you are testing a kind of timescale migration).

@vokimon vokimon self-assigned this Oct 5, 2023
@anxodio
Copy link
Author

anxodio commented Oct 10, 2023

@anxodio thanks por the PR. I integrated it since the incompatibility and pinning are correct. But, do yo need a release, and/or deploy? Which is the use you are doing of it? (i guess you are testing a kind of timescale migration).

Potser ho necessitarem per Generation. La cosa es que s'han de mostrar dades de consum que estan a mongo per unes gràfiques a la Oficina Virtual, i analitzant com està fet en els casos de consum normal entenem que hauriem de fer-ho a Heman. Ententem que potser Heman té data de caducitat, però infoenergia no autentica per usuari i no el podem fer servir sense una feina previa.

Per tant la idea (quan hi arribem, ara estem amb una altre cosa que va directament a webforms-api), era fer la proposta sobre Heman, deixant-la estructuralment igual que el que hi ha muntat per després migrar-ho fàcilment tot junt quant toqui

@anxodio anxodio deleted the fix_flask_cors_py2_dependence branch October 11, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants