Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix decode unexpected param #2

Merged
merged 3 commits into from
Dec 22, 2021
Merged

Fix decode unexpected param #2

merged 3 commits into from
Dec 22, 2021

Conversation

BenjiRS94
Copy link

  • When sermepa revice an unexpected param in decodeSignedData method not will raise SignatureError
  • Create new order id in tests because Redsys test environment have persistence

@BenjiRS94 BenjiRS94 self-assigned this Dec 2, 2021
juan-pe
juan-pe approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@juan-pe juan-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!! Thanks! 👍

vokimon
vokimon approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@vokimon vokimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantabulous.

@BenjiRS94 BenjiRS94 merged commit eb2b17d into master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vokimon vokimon vokimon approved these changes

@juan-pe juan-pe juan-pe approved these changes

Assignees

@BenjiRS94 BenjiRS94

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@BenjiRS94 @vokimon @juan-pe