Improve use of mocks in somenergia_soci_tests #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susu105
approved these changes
Jan 22, 2021
MarJene
force-pushed
the
IMP_mailchimp_tests
branch
from
20758ff
to
3385709
Compare
MarJene
force-pushed
the
IMP_mailchimp_tests
branch
from
3385709
to
1fd9e28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Estàvem assignant els
return_valuedels mocks just després de fer la crida a la funció que voliem testejar. Degut a això, es va haver d'utilitzarmock.ANYaassert_called_with, perque els valors no eren els esperats.Solució: moure l'assignament a
return_valueabans de la crida a la funció.