🎨 changes required by sonar linter

backend/datasources/erp.py

@@ -39,7 +39,7 @@ def catch_validation_error():
     NoDocumentVersions,
 ]
 def process_erp_errors(erp_response):
-    if not 'error' in erp_response: return
+    if 'error' not in erp_response: return
     erp_errors = {
         excp.__name__: excp
         for excp in expected_erp_exceptions

backend/erp.py

@@ -8,13 +8,10 @@
 # TODO; Use erppeek, connection pool management, transactions...
 
 @decorator
-def requiresToken(f, self, *args, **kwds):
-    try:
-        if not self._token:
-            self.token()
-        return f(self, *args, **kwds)
-    except Exception as e:
-        raise 
+def requires_token(f, self, *args, **kwds):
+    if not self._token:
+        self.token()
+    return f(self, *args, **kwds)
 
 class ErpConnectionError(Exception): pass
 
@@ -56,7 +53,7 @@ def _post(self, endpoint, *args):
     def token(self):
         self._token = self._post('/common', 'token', self.db, self.user, self.password)
 
-    @requiresToken
+    @requires_token
     def object_execute(self, *args):
         return self._post('/object', 'execute', self.db, 'token', self._token, *args)