Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Manage pdf download errors #13

Merged
merged 7 commits into from
Dec 29, 2023
Merged

✨ Manage pdf download errors #13

merged 7 commits into from
Dec 29, 2023

Conversation

vokimon
Copy link
Member

@vokimon vokimon commented Dec 27, 2023 •
edited
Loading

Description

Turn pdf download into a managed axios query in order to manage errors

Changes

  • Instead of changing location delegate into axios and manage the response to generate a download
  • Special button to handle state of each download

Observations

image

Please, review

  • No regression:
    • Local file name is ok
    • PDF are opened in a diferent tab
    • PDF are opened as local file
  • On error an error is displayed
    • Error not such user
    • Error not such invoice
    • Error not authorized (invoice does not belong to the user)
    • Connection error

How to check the new featuresnot such user

Deploy notes

@vokimon vokimon added the enhancement New feature or request label Dec 27, 2023
@vokimon vokimon self-assigned this Dec 27, 2023
@vokimon vokimon force-pushed the IMP_managed_pdf_download branch 3 times, most recently from 55aaef4 to bc5149b Compare December 28, 2023 06:21
@coveralls
Copy link

coveralls commented Dec 28, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7356270016

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 71.069%
Totals Coverage Status
Change from base Build 7356258405: 0.2%
Covered Lines: 482
Relevant Lines: 651
💛 - Coveralls

@vokimon
✨ Manage pdf download errors
c93efbd 
Turn pdf download into a managed axios query in order
to manage errors
@vokimon
🐛 download clean up and safety
183aaa0
@vokimon
🐛 wrong variable names in cleanup code
75614ac
@vokimon
💄 DownloadButton gives feedbacks about state
bde8bd3 
- As you press it, turns into a progress
- When completed successful, green check
- When error, red warning
- Click on it again and you can try again
@vokimon
💄 Download button provide tooltip to explain status
960fd57 
Errors are shown on the tooltip but when ongoing or success
@vokimon
✨ Handling NoSuchInvoice from erp, and dummy for pdf errors
62ba9ad
@vokimon
📝 CHANGEs
692e49c
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 29, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

12 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vokimon vokimon merged commit b839bb3 into main Dec 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariteSomEnergia MariteSomEnergia Awaiting requested review from MariteSomEnergia

@marta197 marta197 Awaiting requested review from marta197

Assignees

@vokimon vokimon

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vokimon @coveralls