Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Details fields typing and formatting #14

Merged
merged 16 commits into from
Dec 29, 2023
Merged

Details fields typing and formatting #14

merged 16 commits into from
Dec 29, 2023

Conversation

vokimon
Copy link
Member

@vokimon vokimon commented Dec 28, 2023 •
edited
Loading

Description

A review of Details fields: validations and formating

Changes

  • All enums are now validated as such with the set of fields provided by ERP (hardcoded, not queried to the erp)
    • BillingMode, RepresentationType, ContractStatus, ProductionTechnology, DeviationIncluded
  • Format functions are used for dates and numbers, localized and with thousand separator.
  • Units are not in the label anymore but together with the number (Potencia nominal, Retribucion representante)
  • Technologies are not displayed by a single or two letters but with a human description
  • Cost deviation 'not_included' was not properly displayed, now translated 'No incluido'
  • Contract status was hardcoded to always be 'Activo', now we get any status from ERP and translate it.
  • New format function for unit based quantities

Observations

imatge

Please, review

  • Translations of contract statuses are quite free
  • Are there any more production technologies out there?

How to check the new features

Deploy notes

@vokimon
✨ units formatting helper
f46f5b7
@vokimon
♻️ API validates most ERP enums
cdb0b03 
Added enums
- BillingMode (atr, indexada)
- RepresentationType (directa_cnmc, indirecta_cnmc)
- ProductionTechnology (FV, E, H) (Photovoltaic, Eolic, Hydro)
- DeviationInclude (included, not_included)
- ContractStatus (esborany, activa, pendent, modificacio...)
@vokimon
✨ contract rate_power uses format.unit
2d5c8e8
@vokimon
🐛 Translating technology letters into text
09ea55f
@vokimon
🐛 translating all cost_deviation values
a21382f
@vokimon
💄 locally formating discharge_date
5df923e
@vokimon
🌐 translating all contract status
209ef8a
@vokimon
💄 proxy fee units with the value and local format
a374d69
@vokimon
🎨 using format.percent for reduction_deviation
7ddc62e
@vokimon
🎨 contractData -> contract to short expressions
f88cd1f
@vokimon
🌐 typo Eòlica -> Eólica
4a26cfa
@vokimon vokimon added the enhancement New feature or request label Dec 28, 2023
@vokimon vokimon self-assigned this Dec 28, 2023
@coveralls
Copy link

coveralls commented Dec 28, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7354802992

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 70.876%
Totals Coverage Status
Change from base Build 7345228674: 0.2%
Covered Lines: 479
Relevant Lines: 646
💛 - Coveralls

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 29, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

9.6% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@vokimon vokimon merged commit 0c2ccdd into main Dec 29, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javikalsan javikalsan Awaiting requested review from javikalsan

@JoanaFigueira JoanaFigueira Awaiting requested review from JoanaFigueira

@marta197 marta197 Awaiting requested review from marta197

Assignees

@vokimon vokimon

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vokimon @coveralls