Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Download zip file with invoices #21

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Conversation

MariteSomEnergia
Copy link
Contributor

Description

Allow to download a zip file with selected invoices. Several zip are generated with maximum lenght of 12 invoice pdfs by zip file.

Changes

  • Add necessary backend to call erp method download_invoices_zip in som_ov_invoices of somrepresenta-erp-modules repository
  • Add a call that gestionate the numeber of zip created
  • Add dummy to test in local
  • Add a model InvoicesZip
  • Add DownloadZipButton funcionality

Please, review

  • Type of files: application/zip
  • responseType in axios

How to check the new features

Select several invoices and click on download files icon

@MariteSomEnergia MariteSomEnergia self-assigned this Feb 22, 2024
@MariteSomEnergia MariteSomEnergia added the enhancement New feature or request label Feb 22, 2024
@coveralls
Copy link

coveralls commented Feb 22, 2024

Pull Request Test Coverage Report for Build 8109709535

Details

  • 21 of 54 (38.89%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.2%) to 65.658%

Changes Missing Coverage Covered Lines Changed/Added Lines %
backend/datasources/init.py 1 2 50.0%
backend/erp.py 1 2 50.0%
backend/api_business.py 5 8 62.5%
backend/utils/responses.py 3 8 37.5%
backend/datasources/erp.py 2 8 25.0%
backend/datasources/dummy.py 5 22 22.73%
Totals Coverage Status
Change from base Build 7988047166: -2.2%
Covered Lines: 534
Relevant Lines: 778

💛 - Coveralls

Copy link
Member

@vokimon vokimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool feature and elegant solution. Suggested improvements not critical for merging. Although should we merge the csv dependent branch first?

backend/datasources/__init__.py Outdated Show resolved Hide resolved
backend/datasources/dummy.py Show resolved Hide resolved
backend/datasources/dummy.py Outdated Show resolved Hide resolved
backend/datasources/dummy.py Outdated Show resolved Hide resolved
frontend/src/services/download.js Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
15 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MariteSomEnergia MariteSomEnergia merged commit 4fd119d into main Mar 7, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants