New delete case endpoint #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BenjiRS94
force-pushed
the
NEW_delete_case_endpoint
branch
from
5d55a4f
to
d65d0dd
Compare
vokimon
requested changes
Mar 14, 2023
There was a problem hiding this comment.
This helper is used to assert in test, doing this change is like faking the assert to be always true. You should either pick as fixture a new template that has no en_US translation, or adding en_US as supported traslation as previous version of the PR did but then change the unsupported language in test__save_template__bodyTranslation_cloneExistingUnsupported to be other than en_US
For bodies, not for subjects, language is managed by the mako code, so whichever translation exist it must be written with the code we have.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Case
We needed to create an endpoint to delete template test cases (in case we wrote a wrong ID, or something).
Proposed solution
We created an endpoint with a delete method to delete the specified template case.