Fix for some tests that were failing on my Mac #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Build the latest version of the rhino less version 2. Use the latest version to test against Also update Grunt build to have a build rhino task
|
Thanks a lot. |
|
Shoot - looks like I messed up the branch - this should really only be the first two commits |
|
Closing as a duplicate of #12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses the system file separator instead of a hard coded slash for finding the expected css file. This fixes the tests that were failing on my Mac. Also the expectedCssPath closure was mostly duplicated in the base class (RhinoTest) and subclass (DebugRhinoTest) so I moved a common version to the base class so they could both use the same code.