Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when using read_adat() + issue in setup script #40

Closed
1 of 5 tasks
Hijinx725 opened this issue Apr 18, 2023 · 2 comments · Fixed by #41
Closed
1 of 5 tasks

Error when using read_adat() + issue in setup script #40

Hijinx725 opened this issue Apr 18, 2023 · 2 comments · Fixed by #41
Assignees
Labels
bug Something isn't working

Comments

@Hijinx725
Copy link

Hijinx725 commented Apr 18, 2023

Checks

  • Please search previous issues before creating a new one,
    to ensure yours is not a duplicate. You can
    edit the qualifiers,
    is:pr, is:closed, etc., as needed, e.g. you'd simply remove is:open to
    search all issues in the repo, open or closed.
  • Please include a minimal reproducible example (AKA a reprex)

If you've never heard of a reprex before,
please start by reading https://www.tidyverse.org/help/#reprex.


Description

Please briefly describe the problem you have encountered
and what output you expected ...

I tired this code from the readme:

f <- system.file("extdata", "example_data10.adat",
package = "SomaDataIO", mustWork = TRUE)
my_adat <- read_adat(f)
is.soma_adat(my_adat)
my_adat

Also, in /data_raw/SomaScanObjects.R there is a missing ')' in the second function.

Output

Error in gsub_(st$close, st$open, text, fixed = TRUE, useBytes = TRUE) : 
  could not find function "gsub_"
In addition: Warning message:
In is_string(left) : restarting interrupted promise evaluation

Expected Output

table

Steps

Please describe any steps you have already taken that may
assist in reproducing the (unexpected) behavior:

  • installed SomaDataIO from R ( version 4.1.2 )
  • installed missing required packages listed in readme

Priority Level

  • High
  • Medium
  • Low

Thanks for reporting 🥳!

@Hijinx725 Hijinx725 added the bug Something isn't working label Apr 18, 2023
@stufield stufield self-assigned this Apr 18, 2023
@stufield
Copy link
Contributor

stufield commented Apr 18, 2023

Hi @Hijinx725 ,

  • unfortunately I am unable to reproduce the error you are experiencing. Could you please generate a proper reprex that reproduces the error? Specifically, which version of SomaDataIO you are using (v6.0.0?)
  • the SomaScanObjects.R script is meant for updating package objects only, and is not intended for end user interaction (see .Rbuildignore). However, thank you for the catch, I will fix in an upcoming PR.

Thank you!

@stufield stufield changed the title Error when using read_adapt + issue in code Error when using read_adat() + issue in code Apr 18, 2023
stufield added a commit that referenced this issue Apr 18, 2023
- missing in SomaScanObjects.R
- fixes #40
@stufield stufield changed the title Error when using read_adat() + issue in code Error when using read_adat() + issue in setup script Apr 18, 2023
stufield added a commit that referenced this issue Apr 18, 2023
@stufield
Copy link
Contributor

stufield commented Apr 18, 2023

@Hijinx725 was this issue resolved?

I'm re-opening this issue so the PR can close it when merged

@stufield stufield reopened this Apr 18, 2023
stufield added a commit that referenced this issue Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants