Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak to S3 tidyr::separate.soma_adat() #72

Closed
stufield opened this issue Jan 5, 2024 · 0 comments · Fixed by #73
Closed

Tweak to S3 tidyr::separate.soma_adat() #72

stufield opened this issue Jan 5, 2024 · 0 comments · Fixed by #73

Comments

@stufield
Copy link
Contributor

stufield commented Jan 5, 2024

Minor update from internal code base to simplify the internal S3 method and how it uses lazyeval.
stufield added a commit to stufield/SomaDataIO that referenced this issue Jan 5, 2024
@stufield
Simplify tidyr::separate.soma_adat() S3 method
baf7513 
- simplified code using `%||%`
- added expeanded error messages inside `stopifnot()`
- minor fix of unit test syntax
- fixes SomaLogic#72
@stufield stufield mentioned this issue Jan 5, 2024
Merged
stufield added a commit that referenced this issue Jan 5, 2024
@stufield
Simplify tidyr::separate.soma_adat() S3 method
50e8a42 
- simplified code using `%||%`
- added expeanded error messages inside `stopifnot()`
- minor fix of unit test syntax
- fixes #72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify tidyr::separate.soma_adat() S3 method stufield/SomaDataIO
1 participant
@stufield