New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapsing ADATs strips the PlateScale information in Header #86
Comments
stufield
added
enhancement
GSE
Specific issues created by SomaLogic, GSE Team
feature
New feature or request
and removed
enhancement
labels
Feb 13, 2024
stufield
added a commit
to stufield/SomaDataIO
that referenced
this issue
Mar 18, 2024
- collapseAdats() now does a better job of maintaining useful information when combining ADATs during the collapse - PlateScale* and Cal* information is now merged, rather than concatenated, resulting in shorter set of attributes - new values in downstream ADATs are maintained, and no longer lost when written - the majority of HEADER iformation is still that of the first, initial ADAT in the list - the stopifnot() call gets more clear error message - closes SomaLogic#86
stufield
added a commit
to stufield/SomaDataIO
that referenced
this issue
Mar 18, 2024
- collapseAdats() now does a better job of maintaining useful information when combining ADATs during the collapse - PlateScale* and Cal* information is now merged, rather than concatenated, resulting in shorter set of attributes - new values in downstream ADATs are maintained, and no longer lost when written - the majority of HEADER iformation is still that of the first, initial ADAT in the list - the stopifnot() call gets more clear error message - closes SomaLogic#86
stufield
added a commit
to stufield/SomaDataIO
that referenced
this issue
Mar 18, 2024
- collapseAdats() now does a better job of maintaining useful information when combining ADATs during the collapse - PlateScale* and Cal* information is now merged, rather than concatenated, resulting in shorter set of attributes - new values in downstream ADATs are maintained, and no longer lost when written - the majority of HEADER iformation is still that of the first, initial ADAT in the list - the stopifnot() call gets more clear error message - closes SomaLogic#86
stufield
added a commit
to stufield/SomaDataIO
that referenced
this issue
Mar 18, 2024
- `collapseAdats()` now does a better job of maintaining useful information when combining ADATs during the collapse - `PlateScale*` and `Cal*` information is now merged, rather than concatenated, resulting in shorter set of attributes - new values in downstream ADATs are maintained, and no longer lost when written - the majority of HEADER information is still that of the first, initial ADAT in the list - the `stopifnot()` call gets more clear error message - closes SomaLogic#86
stufield
added a commit
to stufield/SomaDataIO
that referenced
this issue
Mar 18, 2024
- `collapseAdats()` now does a better job of maintaining useful information when combining ADATs during the collapse - `PlateScale*` and `Cal*` information is now merged, rather than concatenated, resulting in shorter set of attributes - new values in downstream ADATs are maintained, and no longer lost when written - the majority of HEADER information is still that of the first, initial ADAT in the list - the `stopifnot()` call gets more clear error message - closes SomaLogic#86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
When combining ADAT files in
loadAdatsAsList()
, the header information is retained for only the first file.This is by design because hundreds of ADATs could be combined, bloating the attributes.
However, the
PlateScale
information could be of value.Feature
Modify the
PlateScale
key-value pair to retain the scaling information from all the ADATs in the collapsed list.Notify: @wschwarzmann
Priority Level
Thanks for contributing 🥳!
The text was updated successfully, but these errors were encountered: