Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new merge_clin() function for export #96

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

stufield
Copy link
Contributor

Summary

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.51%. Comparing base (e433267) to head (a79f778).

❗ Current head a79f778 differs from pull request most recent head 9feb212. Consider uploading reports for the commit 9feb212 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   75.30%   75.51%   +0.21%     
==========================================
  Files          41       42       +1     
  Lines        1478     1491      +13     
==========================================
+ Hits         1113     1126      +13     
  Misses        365      365              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stufield stufield force-pushed the add-clinical-merge-function branch 3 times, most recently from 958e58c to efad5e7 Compare March 12, 2024 16:03
@stufield stufield requested a review from scheidec March 12, 2024 17:07
@stufield stufield force-pushed the add-clinical-merge-function branch 3 times, most recently from 51ae661 to 458ac0f Compare March 12, 2024 19:03
Copy link
Contributor

@scheidec scheidec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few minor grammatical changes suggested.

R/merge-clin.R Outdated Show resolved Hide resolved
tests/testthat/test-merge-clin.R Outdated Show resolved Hide resolved
vignettes/cli-merge-tool.Rmd Outdated Show resolved Hide resolved
vignettes/cli-merge-tool.Rmd Outdated Show resolved Hide resolved
- new function wrapper to allow users
  to merge in clinical variables to `soma_adat`
  objects easily
- closes SomaLogic#80
@stufield stufield force-pushed the add-clinical-merge-function branch from 4db0496 to 3100b70 Compare March 13, 2024 13:34
- vignettes triggered a warning about the missing
  favicon in the articles footer
- the path spec was a level off
- this fixes the issue; no more warnings and
  the logo is on all articles
@stufield stufield merged commit 3593a0e into SomaLogic:main Mar 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move merge_clin.R functionality from Rscript to an exported function
3 participants