Fixed metadata propagation in Dataframe.idxmax and Dataframe.idxmin p…

…andas-dev#28283
SomtochiUmeh · Jul 22, 2022 · 05fdeb3 · 05fdeb3
1 parent bedd8f0
commit 05fdeb3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/pandas/core/frame.py b/pandas/core/frame.py
@@ -11010,7 +11010,7 @@ def idxmin(
 
         index = data._get_axis(axis)
         result = [index[i] if i >= 0 else np.nan for i in indices]
-        return data._constructor_sliced(result, index=data._get_agg_axis(axis))
+        return data._constructor_sliced(result, index=data._get_agg_axis(axis)).__finalize__(self, method="idxmin")
 
     @doc(_shared_docs["idxmax"], numeric_only_default="False")
     def idxmax(
@@ -11035,7 +11035,7 @@ def idxmax(
 
         index = data._get_axis(axis)
         result = [index[i] if i >= 0 else np.nan for i in indices]
-        return data._constructor_sliced(result, index=data._get_agg_axis(axis))
+        return data._constructor_sliced(result, index=data._get_agg_axis(axis)).__finalize__(self, method="idxmax")
 
     def _get_agg_axis(self, axis_num: int) -> Index:
         """

diff --git a/pandas/tests/generic/test_finalize.py b/pandas/tests/generic/test_finalize.py
@@ -227,12 +227,10 @@
         (pd.DataFrame, frame_data, operator.methodcaller("nunique")),
     ),
     pytest.param(
-        (pd.DataFrame, frame_data, operator.methodcaller("idxmin")),
-        marks=not_implemented_mark,
+        (pd.DataFrame, frame_data, operator.methodcaller("idxmin"))
     ),
     pytest.param(
-        (pd.DataFrame, frame_data, operator.methodcaller("idxmax")),
-        marks=not_implemented_mark,
+        (pd.DataFrame, frame_data, operator.methodcaller("idxmax"))
     ),
     pytest.param(
         (pd.DataFrame, frame_data, operator.methodcaller("mode")),