SONARERLNG-19 fix nullpointer in tail recursive check

SonarQubeCommunity · Feb 26, 2015 · ff81da2 · ff81da2
1 parent bdd2523
commit ff81da2
Show file tree

Hide file tree

Showing 3 changed files with 2,164 additions and 0 deletions.
diff --git a/erlang-checks/src/main/java/org/sonar/erlang/checks/IsTailRecursiveCheck.java b/erlang-checks/src/main/java/org/sonar/erlang/checks/IsTailRecursiveCheck.java
@@ -58,6 +58,10 @@ public void visitNode(AstNode node) {
     if (node.getType().equals(ErlangGrammarImpl.functionDeclaration)) {
       actualArity = getArity(node.getFirstChild(ErlangGrammarImpl.functionClause));
     } else if (node.getType().equals(ErlangGrammarImpl.callExpression)
+      /**
+      * Not in a module attribute
+      */
+      && node.getFirstAncestor(ErlangGrammarImpl.defineAttr) == null
       /**
        * Recursive call
        */

diff --git a/erlang-checks/src/test/java/org/sonar/erlang/checks/IsTailRecursiveCheckTest.java b/erlang-checks/src/test/java/org/sonar/erlang/checks/IsTailRecursiveCheckTest.java
@@ -49,4 +49,13 @@ public void test2() {
       .next().atLine(12)
       .noMore();
   }
+
+  @Test
+  public void test_bug() {
+    IsTailRecursiveCheck check = new IsTailRecursiveCheck();
+    SourceFile file = TestHelper.scanSingleFile(new File(
+      "src/test/resources/checks/mod_configure.erl"), check);
+
+
+  }
 }