Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Compilation Database not handling array arguments #1745

Closed
zanettea opened this issue Jul 31, 2019 · 2 comments · Fixed by #1789
Closed

JSON Compilation Database not handling array arguments #1745

zanettea opened this issue Jul 31, 2019 · 2 comments · Fixed by #1789
Assignees
Milestone

Comments

@zanettea
Copy link

zanettea commented Jul 31, 2019

Arguments in JsonCompilationDatabase are only handled as strings, but usually are arrays.

See specification: https://clang.llvm.org/docs/JSONCompilationDatabase.html :

arguments: The compile command executed as list of strings. Either arguments or command is required.

See also clang -MJ fragment.json main.cpp output as reference

@guwirth
Copy link
Collaborator

guwirth commented Aug 1, 2019

Hi @zanettea,

Thanks for your feedback. To fix this issue it would be helpful to provide a sample. Could you add a small Jason sample to this issue please.

Regards,

@guwirth
Copy link
Collaborator

guwirth commented Jan 20, 2020

Thanks to @tisoft for solving this!

@guwirth guwirth assigned guwirth and unassigned guwirth Jan 28, 2020
@guwirth guwirth changed the title JsonCompilationDatabase not handling array arguments JSON Compilation Database not handling array arguments Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants