Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pc-lint errors with line 0 is not saved as a violation in Sonar #51

Closed
wenns opened this issue Nov 15, 2013 · 2 comments
Closed

Pc-lint errors with line 0 is not saved as a violation in Sonar #51

wenns opened this issue Nov 15, 2013 · 2 comments
Labels

Comments

@wenns
Copy link
Contributor

wenns commented Nov 15, 2013

Pc-lint violations with line 0 is only logged as "PCLint warning ignored: ..." and is not saved as a violation in Sonar.
If my analysis is correct this is due to the following:

There is a check in the method processReport in CxxPCLintReportSensor that checks if a line in a pc-lint violation is 0.

If it is 0 then a log entry is created and then just continous to process the next violation.

This check is needed due to that the saveViolation method in CxxReportSensor requires the line to be greater than 0 since it calls

Violation.create(rule, resource).setLineId(line).setMessage(msg);
@wenns
Copy link
Contributor Author

wenns commented Dec 7, 2013

@bert: this one (its quite old, it comes from the Jira) is already implemented and can be closed, no?

@Bertk
Copy link
Contributor

Bertk commented Dec 8, 2013

this solved with #80.

@Bertk Bertk closed this as completed Dec 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants