Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rule S1192 (based on 'eslint-plugin-sonarjs/no-duplicate-string') for TS #1371

Closed
vilchik-elena opened this issue Sep 11, 2019 · 1 comment · Fixed by #1395
Closed

Add rule S1192 (based on 'eslint-plugin-sonarjs/no-duplicate-string') for TS #1371

vilchik-elena opened this issue Sep 11, 2019 · 1 comment · Fixed by #1395
Assignees
@quentin-jaquier-sonarsource
Milestone
6.0

Comments

@vilchik-elena
Copy link
Contributor

Rule is already covered for JS
@vilchik-elena vilchik-elena added this to the 6.0 milestone Sep 11, 2019
@vilchik-elena vilchik-elena mentioned this issue Sep 11, 2019
Closed
67 tasks
Merged
@quentin-jaquier-sonarsource
Copy link
Contributor

Changes in the rule

  • String is now trimmed before being checked for duplicate.
    This may add issues, or remove others that falls under the length threshold.
  • We now ignore object property keys.

These two changes may also change the line on which the issue is reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quentin-jaquier-sonarsource quentin-jaquier-sonarsource

Labels
None yet
Projects
None yet
Milestone
6.0
Development

Successfully merging a pull request may close this issue.

Add rule S1192 (based on 'eslint-plugin-sonarjs/no-duplicate-string') for TS SonarSource/SonarJS
2 participants
@vilchik-elena @quentin-jaquier-sonarsource