Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S1105 (based on brace-style) for JS/TS #1404

Closed
vilchik-elena opened this issue Sep 13, 2019 · 1 comment · Fixed by #1407
Closed

Add S1105 (based on brace-style) for JS/TS #1404

vilchik-elena opened this issue Sep 13, 2019 · 1 comment · Fixed by #1407
Assignees
Milestone

Comments

@vilchik-elena
Copy link
Contributor

brace-style also reports on closing brace before else, we can extend our rule (update JS RSPEC)

@quentin-jaquier-sonarsource
Copy link
Contributor

Changes in the rule

  • Parameter added to select the enforced brace-style (1tbs, stroustrup or allman).

For default parameter (1tbs):

  • new issues when the closing brace is not on the same line as the else, if-else, catch or finally keyword.
  • new issues when a statements inside a brace appears at the same line as the opening or closing brace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants