Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add S1523 (based on code-eval) for TS #1416

Closed
vilchik-elena opened this issue Sep 13, 2019 · 0 comments · Fixed by #1423
Closed

Add S1523 (based on code-eval) for TS #1416

vilchik-elena opened this issue Sep 13, 2019 · 0 comments · Fixed by #1423
Assignees
@yassin-kammoun-sonarsource
Milestone
6.0

Comments

@vilchik-elena
Copy link
Contributor

vilchik-elena commented Sep 13, 2019 •
edited

legacy key used for JS (Eval) and we already have rule impl for JS, it's code-eval, so we should not use no-eval
@vilchik-elena vilchik-elena added this to the 6.0 milestone Sep 13, 2019
@vilchik-elena vilchik-elena mentioned this issue Sep 13, 2019
Closed
67 tasks
This was referenced Sep 16, 2019
Closed
Merged
@vilchik-elena vilchik-elena changed the title Add S1523 (based on no-eval) for TS Add S1523 (based on code-eval) for TS Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource

Labels
None yet
Projects
None yet
Milestone
6.0
Development

Successfully merging a pull request may close this issue.

Add S1523 (based on code-eval) for TS SonarSource/SonarJS
2 participants
@vilchik-elena @yassin-kammoun-sonarsource