Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rule S1656 (based on 'no-self-assign') for TS/JS #1427

Closed
vilchik-elena opened this issue Sep 16, 2019 · 1 comment · Fixed by #1453
Closed

Add rule S1656 (based on 'no-self-assign') for TS/JS #1427

vilchik-elena opened this issue Sep 16, 2019 · 1 comment · Fixed by #1453
Assignees
@saberduck
Milestone
6.0

Comments

@vilchik-elena
Copy link
Contributor

No description provided.

@vilchik-elena vilchik-elena added this to the 6.0 milestone Sep 16, 2019
@vilchik-elena vilchik-elena mentioned this issue Sep 16, 2019
Closed
67 tasks
@saberduck saberduck self-assigned this Sep 16, 2019
@saberduck saberduck mentioned this issue Sep 16, 2019
Merged
@quentin-jaquier-sonarsource
Copy link
Contributor

Changes in the rule

  • eslint implementation doesn't consider mutating functions on arrays sort and reverse, ie. a = a.sort() is not raised
  • eslint implementations detects equivalent expressions which differ due to parenthesis a = (a)
  • no-self-assign doesn't handle member expressions using this, so this.x = this.x is not detected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saberduck saberduck

Labels
None yet
Projects
None yet
Milestone
6.0
Development

Successfully merging a pull request may close this issue.

Add rule S1656 (based on 'no-self-assign') for TS/JS SonarSource/SonarJS
3 participants
@saberduck @vilchik-elena @quentin-jaquier-sonarsource