Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rule S3512 (based on 'prefer-template') for TS/JS #1449

Closed
vilchik-elena opened this issue Sep 16, 2019 · 1 comment · Fixed by #1548
Closed

Add rule S3512 (based on 'prefer-template') for TS/JS #1449

vilchik-elena opened this issue Sep 16, 2019 · 1 comment · Fixed by #1548
Assignees
@quentin-jaquier-sonarsource
Milestone
6.0

Comments

@vilchik-elena
Copy link
Contributor

No description provided.

@vilchik-elena vilchik-elena added this to the 6.0 milestone Sep 16, 2019
@vilchik-elena vilchik-elena mentioned this issue Sep 16, 2019
Closed
67 tasks
Merged
@quentin-jaquier-sonarsource
Copy link
Contributor

Changes in the rule:

  • Rule was in sonar-way-recommended for TS but not for JS: they are now present for both.

New issues when:

For JS and TS:

  • more than 2 operands in concatenation expression.

Only for JS:

  • litteral with less than 6 characters
  • others specific cases not documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quentin-jaquier-sonarsource quentin-jaquier-sonarsource

Labels
None yet
Projects
None yet
Milestone
6.0
Development

Successfully merging a pull request may close this issue.

Add rule S3512 (based on 'prefer-template') for TS/JS SonarSource/SonarJS
2 participants
@vilchik-elena @quentin-jaquier-sonarsource