Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rule S3854 (based on 'constructor-super') for TS #1458

Closed
vilchik-elena opened this issue Sep 16, 2019 · 1 comment · Fixed by #1561
Closed

Add rule S3854 (based on 'constructor-super') for TS #1458

vilchik-elena opened this issue Sep 16, 2019 · 1 comment · Fixed by #1561
Assignees
@vilchik-elena
Milestone
6.0

Comments

@vilchik-elena
Copy link
Contributor

No description provided.

@vilchik-elena vilchik-elena added this to the 6.0 milestone Sep 16, 2019
@vilchik-elena vilchik-elena mentioned this issue Sep 16, 2019
Closed
67 tasks
@vilchik-elena vilchik-elena self-assigned this Sep 19, 2019
@vilchik-elena vilchik-elena changed the title Add rule S3854 (based on 'constructor-super') for TS/JS Add rule S3854 (based on 'constructor-super') for TS Sep 19, 2019
@vilchik-elena
Copy link
Contributor Author

For JS rule scope differs too much so we will continue relying on java-based impl.

For TS rule scope is wider now, we don't only report on duplicate super() but also if it's called in the wrong context (e.g. class does not extend anything)

@vilchik-elena vilchik-elena mentioned this issue Sep 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vilchik-elena vilchik-elena

Labels
None yet
Projects
None yet
Milestone
6.0
Development

Successfully merging a pull request may close this issue.

Add rule S3854 (based on 'constructor-super') for TS SonarSource/SonarJS
1 participant
@vilchik-elena