Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop AST helper getObjectExpressionProperty in favor of getProperty #4271

Closed
yassin-kammoun-sonarsource opened this issue Oct 13, 2023 · 0 comments · Fixed by #4601
Closed

Drop AST helper getObjectExpressionProperty in favor of getProperty #4271

yassin-kammoun-sonarsource opened this issue Oct 13, 2023 · 0 comments · Fixed by #4601
Assignees
@zglicz
Labels
must-have
Milestone
10.13

Comments

@yassin-kammoun-sonarsource
Copy link
Contributor

This helper definition should be removed

SonarJS/packages/jsts/src/rules/helpers/ast.ts

Line 416 in 538ae84

export function getObjectExpressionProperty(

and calls to it should now invoke

SonarJS/packages/jsts/src/rules/helpers/ast.ts

Line 448 in 538ae84

export function getProperty(

Ticket created from a TODO leftover in the codebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zglicz zglicz

Labels
must-have
Projects
None yet
Milestone
10.13
Development

Successfully merging a pull request may close this issue.

Remove getObjectExpressionProperty in favor of getProperty SonarSource/SonarJS
4 participants
@zglicz @vdiez @yassin-kammoun-sonarsource @ilia-kebets-sonarsource