Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FP S6582 (prefer-optional-chain): Update description and severity #4521

Closed
ilia-kebets-sonarsource opened this issue Jan 24, 2024 · 1 comment · Fixed by #4562
Closed

Fix FP S6582 (prefer-optional-chain): Update description and severity #4521

ilia-kebets-sonarsource opened this issue Jan 24, 2024 · 1 comment · Fixed by #4562
Assignees
@yassin-kammoun-sonarsource
Labels
mmf-2934 https://sonarsource.atlassian.net/browse/MMF-2934
Milestone
10.12

Comments

@ilia-kebets-sonarsource
Copy link
Contributor

  • Check ES version
  • Update the rule description to give examples of chaining on function calls (o.f?.(arg)) and array accesses (o.arr?.[idx]).
  • Reduce defaultSeverity to minor
@ilia-kebets-sonarsource ilia-kebets-sonarsource added the mmf-2934 https://sonarsource.atlassian.net/browse/MMF-2934 label Jan 24, 2024
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource added this to the 10.12 milestone Feb 8, 2024
@yassin-kammoun-sonarsource
Copy link
Contributor

  • Check ES version

As discussed during a standup, let's have a proper sprint to extract the ECMAScript version used by a project.

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource changed the title Fix FP S6582 (prefer-optional-chain): Check ES version, update description to handle function calls and array index access, update defaultSeverity Fix FP S6582 (prefer-optional-chain): Update description and severity Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource

Labels
mmf-2934 https://sonarsource.atlassian.net/browse/MMF-2934
Projects
None yet
Milestone
10.12
Development

Successfully merging a pull request may close this issue.

Fix FP S6582 (prefer-optional-chain): Update description and severity SonarSource/SonarJS
3 participants
@yassin-kammoun-sonarsource @ilia-kebets-sonarsource @ericmorand-sonarsource