Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jest maxWorkers more robust and adaptable #4587

Closed
ilia-kebets-sonarsource opened this issue Feb 29, 2024 · 1 comment
Closed

Make jest maxWorkers more robust and adaptable #4587

ilia-kebets-sonarsource opened this issue Feb 29, 2024 · 1 comment
Labels
jira-import_24-04-2024 The issue have been imported in jira on 24-04-2024 nice-to-have type: non-functional internal changes to testing or refactoring

Comments

@ilia-kebets-sonarsource
Copy link
Contributor

We have currently 2 values that must work in concert for the CI:

  • task.cpu in cirrus.yml
  • maxWorkers parameter in jest command in package.json

PR: #4583

To make this more robust, we will introduce a test that checks that these 2 values respect the following formula:

maxWorkers = CPU - 2

We would like the value of maxWorkers to be more easily adaptable on dev machines, since the hardware is varied and different from our CI.
For this, we would need to have a different test command executed whether or not IS_CI is true.
We would probably keep a % value for maxWorkers for the dev environment.

@ilia-kebets-sonarsource ilia-kebets-sonarsource added the type: non-functional internal changes to testing or refactoring label Feb 29, 2024
@ilia-kebets-sonarsource ilia-kebets-sonarsource added this to the 10.13 milestone Mar 18, 2024
@zglicz zglicz removed this from the 10.13 milestone Mar 28, 2024
@Wohops Wohops added the jira-import_24-04-2024 The issue have been imported in jira on 24-04-2024 label Apr 24, 2024
@Wohops Wohops closed this as completed Apr 24, 2024
@Wohops
Copy link
Contributor

Wohops commented Apr 24, 2024

Migrated to Jira. New ticket number: JS-27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira-import_24-04-2024 The issue have been imported in jira on 24-04-2024 nice-to-have type: non-functional internal changes to testing or refactoring
Projects
None yet
Development

No branches or pull requests

3 participants