Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps and fix types #359

Merged
merged 5 commits into from
Jul 20, 2022
Merged

Update deps and fix types #359

merged 5 commits into from
Jul 20, 2022

Conversation

saberduck
Copy link
Contributor

No description provided.

@saberduck saberduck force-pushed the update_deps_14 branch 3 times, most recently from 13b9fb2 to 4b3f846 Compare July 20, 2022 10:01
ilia-kebets-sonarsource
ilia-kebets-sonarsource approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except maybe put back the Node 14 CI check as we still support that version of Node? I'm not totally clear on the goal of these checks.

@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@saberduck saberduck merged commit b211bf1 into master Jul 20, 2022
@saberduck saberduck deleted the update_deps_14 branch July 20, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilia-kebets-sonarsource ilia-kebets-sonarsource ilia-kebets-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saberduck @ilia-kebets-sonarsource