Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Node.js 14 support and test against Node.js 20 on CI #445

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Drop Node.js 14 support and test against Node.js 20 on CI #445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d3b3f4
Drop Node.js 14 support
yassin-kammoun-sonarsource Feb 9, 2024
e929a3b
Test against Node.js 20 on CI
yassin-kammoun-sonarsource Feb 9, 2024
b51d545
Fix Node.js downloading source
yassin-kammoun-sonarsource Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions .cirrus.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,20 +46,20 @@
- ./scripts/test-ci.sh
- ./scripts/analyze_and_publish.sh

qa_task:

Check warning on line 49 in .cirrus.yml

View check run for this annotation

Cirrus CI / Build Parsing Results

.cirrus.yml#L49 

task "qa" depends on task "build", but their only_if conditions are different

Check warning on line 49 in .cirrus.yml

View check run for this annotation

Cirrus CI / Build Parsing Results

.cirrus.yml#L49 

task "qa" depends on task "build", but their only_if conditions are different

Check warning on line 49 in .cirrus.yml

View check run for this annotation

Cirrus CI / Build Parsing Results

.cirrus.yml#L49 

task "qa" depends on task "build", but their only_if conditions are different
depends_on:
- build
eks_container:
matrix:
- docker_arguments:
NODE_VERSION: 14
CIRRUS_AWS_ACCOUNT: ${CIRRUS_AWS_ACCOUNT}
- docker_arguments:
NODE_VERSION: 16
CIRRUS_AWS_ACCOUNT: ${CIRRUS_AWS_ACCOUNT}
- docker_arguments:
NODE_VERSION: 18
CIRRUS_AWS_ACCOUNT: ${CIRRUS_AWS_ACCOUNT}
- docker_arguments:
NODE_VERSION: 20
CIRRUS_AWS_ACCOUNT: ${CIRRUS_AWS_ACCOUNT}
<<: *CONTAINER_DEFINITION
cpu: 3
memory: 8G
Expand Down
3 changes: 2 additions & 1 deletion .cirrus/nodejs.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ USER root
ARG NODE_VERSION=18
ARG SCANNER_VERSION=5.0.1.3006

RUN apt-get update && apt-get install -y nodejs=${NODE_VERSION}.*
RUN curl -fsSL https://deb.nodesource.com/setup_${NODE_VERSION}.x | bash - \
&& apt-get install -y nodejs=${NODE_VERSION}.*

RUN curl "https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/sonar-scanner-cli-${SCANNER_VERSION}.zip" -o /tmp/sonar-scanner.zip \
&& unzip -d /opt /tmp/sonar-scanner.zip \
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ Code Smells, or maintainability issues, are raised for places of code which migh

## Prerequisites

- Node.js (>=14.x).
- Node.js (>=16.x).
- ESLint 5.x, 6.x, 7.x or 8.x (peer dependency for the plugin).

## Usage
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
},
"homepage": "https://github.com/SonarSource/eslint-plugin-sonarjs",
"engines": {
"node": ">=14"
"node": ">=16"
},
"scripts": {
"build": "rimraf lib && tsc -d -p tsconfig.json",
Expand Down