Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQHELM-118 fix unsupported wget parameter #312

Merged
merged 1 commit into from Mar 28, 2023

Conversation

jCOTINEAU
Copy link
Contributor

No description provided.

@jCOTINEAU jCOTINEAU self-assigned this Mar 24, 2023
@jCOTINEAU jCOTINEAU force-pushed the feature/jc/SQHELM-118-fix-proxy-bug branch from ecbb664 to 9e75a4d Compare March 24, 2023 14:41
charts/sonarqube-dce/CHANGELOG.md Outdated Show resolved Hide resolved
charts/sonarqube-dce/Chart.yaml Outdated Show resolved Hide resolved
charts/sonarqube-dce/Chart.yaml Outdated Show resolved Hide resolved
charts/sonarqube/Chart.yaml Outdated Show resolved Hide resolved
@jCOTINEAU jCOTINEAU force-pushed the feature/jc/SQHELM-118-fix-proxy-bug branch from 9e75a4d to c97bef5 Compare March 27, 2023 07:05
Copy link
Contributor

@carminevassallo carminevassallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jCOTINEAU jCOTINEAU merged commit 2d9bd44 into master Mar 28, 2023
4 checks passed
@jCOTINEAU jCOTINEAU deleted the feature/jc/SQHELM-118-fix-proxy-bug branch March 28, 2023 07:10
@bbodenmiller
Copy link

Any chance this can be backported to 8.x chart? Or a workaround that folks affected by this could put in place while waiting? We manually removed readiness probe but it seems there should be a better solution.

@jCOTINEAU
Copy link
Contributor Author

jCOTINEAU commented Mar 30, 2023

Hello @bbodenmiller, it is not planed yet, i will grab some information and get back to you soon.

Right now as a quick workaround you could use helm post render to kustomize those probe and replace them with the correct options, or increase the timeout for the probe, that also might be used as a workaround, if your have a timeout greater then the DNS timeout i believe

I am really sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants