This repository has been archived by the owner on May 6, 2021. It is now read-only.
Add support of SonarQube 7.8 (#39) #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienlancelot
force-pushed
the
feature/jl/upgrade_to_7.8
branch
from
ff6e480
to
fa8812f
Compare
ghost
approved these changes
Jun 20, 2019
develop.md
Outdated
| @@ -45,6 +47,9 @@ This was tricky on Ubuntu 2018: | |||
| ALTER USER 'root'@'localhost' IDENTIFIED BY 'rootsonar'; | |||
| flush privileges; | |||
|
|
|||
| If you're using vagrant image, you may need to specify the shema by adding this parameter (update the value to the schema you're using) : | |||
| sonar.jdbc.schema=sonar | |||
There was a problem hiding this comment.
Nitpick on markdown: please add a blank line before this code block, for a more clear visual separation from the text before it.
And, other properties settings in this document are using spaces around the = (because I find that easier to read).
I think it's good to be consistent, so I would add spaces here too, or if you have something against that writing style, then it would be good to change everywhere.
develop.md
Outdated
| @@ -45,6 +47,9 @@ This was tricky on Ubuntu 2018: | |||
| ALTER USER 'root'@'localhost' IDENTIFIED BY 'rootsonar'; | |||
| flush privileges; | |||
|
|
|||
| If you're using vagrant image, you may need to specify the shema by adding this parameter (update the value to the schema you're using) : | |||
There was a problem hiding this comment.
Nitpick: there should not be a space in front of a : in English
julienlancelot
force-pushed
the
feature/jl/upgrade_to_7.8
branch
from
8ff8c15
to
a82ff78
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.