Modify rule S4018: modify message to make it clear the rule is about type inference #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zsolt-kolbay-sonarsource please update the PR title to match the guideline : https://github.com/SonarSource/rspec#to-modify-an-existing-rule
Add the link to the implementation ticket: https://github.com/SonarSource/rspec#3-create-an-implementation-ticket This is necessary for the automation for https://sonarsource.github.io/rspec/ |
zsolt-kolbay-sonarsource
changed the title
|
SonarQube Quality Gate for 'rspec-tools'
|
|
SonarQube Quality Gate for 'rspec-frontend'
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule's message and description were too vague. They didn't make it clear that the type parameters need to be used in the argument list in order to enable type inference when the method is called. Those texts in the rule were updated to reflect that.
Implementation ticket: SonarSource/sonar-dotnet/issues/6636