Create rule S6748: React children should not be passed as prop
#3014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
alex-sonar
changed the title
alex-sonar
changed the title
children should not be passed as prop
yassin-kammoun-sonarsource
requested changes
Sep 8, 2023
| @@ -0,0 +1,26 @@ | |||
| { | |||
| "title": "React \"children\" should not be passed as prop", | |||
There was a problem hiding this comment.
Suggested change
| "title": "React \"children\" should not be passed as prop", | |
| "title": "React children components should not be passed as prop", |
There was a problem hiding this comment.
I don't like the word components here because it can be interpreted as components only, i.e. excluding plain html elements or text content. So I will keep the title as is.
|
|
||
| React.createElement("div", { children: 'Children' }) | ||
| ---- | ||
|
|
There was a problem hiding this comment.
Could you add a brief sentence explaining how to pass from the noncompliant to the compliant snippet?
yassin-kammoun-sonarsource
approved these changes
Sep 11, 2023
Co-authored-by: Yassin Kammoun <52890329+yassin-kammoun-sonarsource@users.noreply.github.com>
|
SonarQube Quality Gate for 'rspec-tools'
|
|
SonarQube Quality Gate for 'rspec-frontend'
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can preview this rule here (updated a few minutes after each push).
SonarSource/SonarJS#4129
Review
A dedicated reviewer checked the rule description successfully for: