Modify S2365: Fix code examples #3923
Conversation
rules/S2365/csharp/rule.adoc
Outdated
| @@ -9,11 +9,21 @@ include::../why-dotnet.adoc[] | |||
| [source,csharp,diff-id=1,diff-type=noncompliant] | |||
| ---- | |||
| private List<string> _foo = new List<string> { "a", "b", "c" }; | |||
There was a problem hiding this comment.
(optional) What about adding using statements as well? Specifically the System.Linq
using System.Collections.Generic;
using System.Linq;There was a problem hiding this comment.
The example context is implicitly set to a class.
Adding usings would be incorrect. I would rather not add them.
rules/S2365/csharp/rule.adoc
Outdated
| @@ -23,9 +33,16 @@ public IEnumerable<string> Foo // Noncompliant: expensive ToList call | |||
| [source,csharp,diff-id=1,diff-type=compliant] | |||
| ---- | |||
| private List<string> _foo = new List<string> { "a", "b", "c" }; | |||
| private string[] _bar = new string[] { "a", "b", "c" }; | |||
There was a problem hiding this comment.
I would take this opportunity to change the field names as well, they should not begin with an underscore IMO
rules/S2365/vbnet/rule.adoc
Outdated
| @@ -8,11 +8,18 @@ include::../why-dotnet.adoc[] | |||
|
|
|||
| [source,vbnet,diff-id=1,diff-type=noncompliant] | |||
| ---- | |||
| Dim foo = {"a", "b", "c" } | |||
| Property Foo() As String() ' Noncompliant | |||
| Private _foo As New List(Of String) From {"a", "b", "c"} | |||
There was a problem hiding this comment.
I added the f prefix for the field names as suggested by @pavel-mikula-sonarsource.
sebastien-marichal
force-pushed
the
sma/fix-s2365
branch
2 times, most recently
from
8dfad8d
to
8c75829
Compare
sebastien-marichal
force-pushed
the
sma/fix-s2365
branch
from
8c75829
to
f10c8f3
Compare
|
|
See SonarSource/sonar-dotnet#9254