Refactor the code to only use 'IsPubliclyAccessible' #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalb-sonar
approved these changes
Jul 7, 2017
| @@ -29,7 +29,7 @@ private class MyPrivateSubClass | |||
|
|
|||
| protected class MyProtectedSubClass | |||
| { | |||
| public double Pi4 = 3.14; | |||
| public double Pi4 = 3.14; // Noncompliant | |||
There was a problem hiding this comment.
Double-check (if you haven't already) that the behaviour is consistent with rspec.
| @@ -61,7 +61,7 @@ protected sealed override void Initialize(SonarAnalysisContext context) | |||
|
|
|||
| if (containingMethod == null || | |||
| containingMethod.IsOverride || | |||
| !containingMethod.IsPublicApi() || | |||
| !containingMethod.IsPubliclyAccessible() || | |||
There was a problem hiding this comment.
Double-check with rspec.
valhristov
suggested changes
Jul 7, 2017
| if (symbol == null || !symbol.IsPublicApi()) | ||
|
|
||
| if (symbol != null && | ||
| symbol.GetEffectiveAccessibility() == Accessibility.Public) |
There was a problem hiding this comment.
You could remove the previous check, GetEffectiveVisibility will handle the null
| { | ||
| return false; | ||
| } | ||
|
|
||
| var effectiveAccessibility = GetEffectiveAccessibility(symbol); | ||
|
|
||
| return effectiveAccessibility == Accessibility.Public || |
There was a problem hiding this comment.
I don't if using a HashSet would be faster...
| return result; | ||
| } | ||
|
|
||
| public static bool IsPubliclyAccessible(this ISymbol symbol) | ||
| { | ||
| if (symbol == null) |
There was a problem hiding this comment.
This is not needed. The next call will return NotApplicable... I don't know if this check will improve performance though... Probably not.
| @@ -36,7 +36,7 @@ protected static bool FieldIsRelevant(IFieldSymbol fieldSymbol) | |||
| return fieldSymbol != null && | |||
| !fieldSymbol.IsStatic && | |||
| !fieldSymbol.IsConst && | |||
| fieldSymbol.IsPublicApi() && | |||
| fieldSymbol.GetEffectiveAccessibility() == Accessibility.Public && | |||
There was a problem hiding this comment.
Why not IsPubliclyAccessible here?
There was a problem hiding this comment.
Because we care only about public fields not protected.
| @@ -58,7 +58,7 @@ protected sealed override void Initialize(SonarAnalysisContext context) | |||
| var symbol = c.SemanticModel.GetDeclaredSymbol(anyVariable) as IFieldSymbol; | |||
| if (symbol == null || | |||
| !symbol.IsConst || | |||
| !symbol.IsPublicApi()) | |||
| symbol.GetEffectiveAccessibility()!= Accessibility.Public) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.