Fix FP S3878: #6893 and #6894 (#9395)

SonarSource · Jun 20, 2024 · 02cdbf2 · 02cdbf2
1 parent 444559d
commit 02cdbf2
Show file tree

Hide file tree

Showing 10 changed files with 96 additions and 389 deletions.
diff --git a/analyzers/its/expected/Ember-MM/S3878-Ember Media Manager.json b/analyzers/its/expected/Ember-MM/S3878-Ember Media Manager.json
diff --git a/analyzers/its/expected/Ember-MM/S3878-generic.EmberCore.NMT.json b/analyzers/its/expected/Ember-MM/S3878-generic.EmberCore.NMT.json
diff --git a/analyzers/its/expected/Ember-MM/S3878-multi.EmberExtras.json b/analyzers/its/expected/Ember-MM/S3878-multi.EmberExtras.json
diff --git a/analyzers/its/expected/Ember-MM/S3878-scraper.EmberCore.XML.json b/analyzers/its/expected/Ember-MM/S3878-scraper.EmberCore.XML.json
diff --git a/analyzers/its/expected/Nancy/S3878-Nancy.ViewEngines.Razor.BuildProviders-net452.json b/analyzers/its/expected/Nancy/S3878-Nancy.ViewEngines.Razor.BuildProviders-net452.json
diff --git a/analyzers/src/SonarAnalyzer.CSharp/Rules/ArrayPassedAsParams.cs b/analyzers/src/SonarAnalyzer.CSharp/Rules/ArrayPassedAsParams.cs
@@ -26,22 +26,22 @@ public sealed class ArrayPassedAsParams : ArrayPassedAsParamsBase<SyntaxKind, Ar
     protected override ILanguageFacade<SyntaxKind> Language => CSharpFacade.Instance;
 
     protected override SyntaxKind[] ExpressionKinds { get; } =
-        {
+        [
             SyntaxKind.ObjectCreationExpression,
             SyntaxKind.InvocationExpression,
             SyntaxKindEx.ImplicitObjectCreationExpression
-        };
+        ];
 
     protected override ArgumentSyntax LastArgumentIfArrayCreation(SyntaxNode expression) =>
-        LastArgumentIfArrayCreation(ArgumentList(expression));
-
-    private static ArgumentSyntax LastArgumentIfArrayCreation(BaseArgumentListSyntax argumentList) =>
-        argumentList is { Arguments: { Count: > 0 } arguments }
+        ArgumentList(expression) is { Arguments: { Count: > 0 } arguments }
         && arguments.Last() is var lastArgument
         && IsArrayCreation(lastArgument.Expression)
             ? lastArgument
             : null;
 
+    protected override ITypeSymbol ArrayElementType(ArgumentSyntax argument, SemanticModel model) =>
+        model.GetTypeInfo(((ArrayCreationExpressionSyntax)argument.Expression).Type.ElementType).Type;
+
     private static BaseArgumentListSyntax ArgumentList(SyntaxNode expression) =>
         expression switch
         {