Fix FP: property marked with JsonRequired attribute

SonarSource · May 21, 2024 · 16c07cd · 16c07cd
1 parent 0371dfa
commit 16c07cd
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/AvoidUnderPosting.cs b/analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/AvoidUnderPosting.cs
@@ -76,7 +76,8 @@ private static void CheckInvalidProperties(INamedTypeSymbol parameterType, Sonar
         var declaredProperties = new List<IPropertySymbol>();
         GetAllDeclaredProperties(parameterType, examinedTypes, declaredProperties);
         var invalidProperties = declaredProperties.Where(x => !CanBeNull(x.Type)
-            && !x.HasAttribute(KnownType.System_ComponentModel_DataAnnotations_RequiredAttribute));
+            && !x.HasAttribute(KnownType.System_ComponentModel_DataAnnotations_RequiredAttribute)
+            && !x.HasAttribute(KnownType.System_Text_Json_Serialization_JsonRequiredAttribute));
         foreach (var property in invalidProperties)
         {
             var propertySyntax = property.DeclaringSyntaxReferences[0].GetSyntax();

diff --git a/analyzers/src/SonarAnalyzer.Common/Helpers/KnownType.cs b/analyzers/src/SonarAnalyzer.Common/Helpers/KnownType.cs
@@ -546,6 +546,7 @@ public sealed partial class KnownType
         public static readonly KnownType System_StringComparison = new("System.StringComparison");
         public static readonly KnownType System_SystemException = new("System.SystemException");
         public static readonly KnownType System_Text_Encoding = new("System.Text.Encoding");
+        public static readonly KnownType System_Text_Json_Serialization_JsonRequiredAttribute = new("System.Text.Json.Serialization.JsonRequiredAttribute");
         public static readonly KnownType System_Text_RegularExpressions_Regex = new("System.Text.RegularExpressions.Regex");
         public static readonly KnownType System_Text_RegularExpressions_RegexOptions = new("System.Text.RegularExpressions.RegexOptions");
         public static readonly KnownType System_Text_StringBuilder = new("System.Text.StringBuilder");

diff --git a/analyzers/tests/SonarAnalyzer.Test/TestCases/AspNet/AvoidUnderPosting.CSharp12.cs b/analyzers/tests/SonarAnalyzer.Test/TestCases/AspNet/AvoidUnderPosting.CSharp12.cs
@@ -28,15 +28,15 @@ namespace Repro9275
     // Repro https://github.com/SonarSource/sonar-dotnet/issues/9275
     public class Model
     {
-        public int ValueProperty { get; set; }        // Noncompliant
+        public int ValueProperty { get; set; }              // Noncompliant
 
-        [Custom]                                      // Noncompliant repro for https://github.com/SonarSource/sonar-dotnet/issues/9282
+        [Custom]                                            // Noncompliant repro for https://github.com/SonarSource/sonar-dotnet/issues/9282
         public int ValuePropertyAnnotatedWithCustomAttribute { get; set; }
 
-        [JsonRequired]                                // Noncompliant - FP because the property is annotated with JsonRequiredAttribute
+        [JsonRequired]                                      // Compliant - the property is annotated with JsonRequiredAttribute
         public int AnotherValueProperty { get; set; }
 
-        public required int RequiredProperty { get; set; } // Noncompliant - FP because the property has the required modifier
+        public required int RequiredProperty { get; set; }  // Noncompliant - FP because the property has the required modifier
     }
 
     public class DerivedFromController : Controller