SE: Remove SymbolicValue.This (#6980)

SonarSource · Apr 4, 2023 · 36de92a · 36de92a
1 parent e970a31
commit 36de92a
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/...yzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/References.cs b/...yzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/References.cs
@@ -25,7 +25,7 @@ namespace SonarAnalyzer.SymbolicExecution.Roslyn.OperationProcessors;
 internal sealed class InstanceReference : ISimpleProcessor
 {
     public ProgramState Process(SymbolicContext context) =>
-        context.State.SetOperationValue(context.Operation, SymbolicValue.This);     // Implicit and Explicit
+        context.State.SetOperationValue(context.Operation, SymbolicValue.NotNull);     // Implicit and Explicit
 }
 
 internal sealed class LocalReference : SimpleProcessor<ILocalReferenceOperationWrapper>

diff --git a/analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/SymbolicValue.cs b/analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/SymbolicValue.cs
@@ -29,7 +29,6 @@ public sealed record SymbolicValue
 
         // Reuse instances to save memory. This "True" has the same semantic meaning and any other symbolic value with BoolConstraint.True constraint
         public static readonly SymbolicValue Empty = new();
-        public static readonly SymbolicValue This = Empty.WithConstraint(ObjectConstraint.NotNull);
         public static readonly SymbolicValue Null = Empty.WithConstraint(ObjectConstraint.Null);
         public static readonly SymbolicValue NotNull = Empty.WithConstraint(ObjectConstraint.NotNull);
         public static readonly SymbolicValue True = NotNull.WithConstraint(BoolConstraint.True);