S1066: Add reproducer for #9221 (#9264)

SonarSource · May 13, 2024 · 37ebbed · 37ebbed
1 parent 07b24bf
commit 37ebbed
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 11 deletions.
diff --git a/analyzers/tests/SonarAnalyzer.Test/Rules/IfCollapsibleTest.cs b/analyzers/tests/SonarAnalyzer.Test/Rules/IfCollapsibleTest.cs
@@ -21,17 +21,16 @@
 using CS = SonarAnalyzer.Rules.CSharp;
 using VB = SonarAnalyzer.Rules.VisualBasic;
 
-namespace SonarAnalyzer.Test.Rules
+namespace SonarAnalyzer.Test.Rules;
+
+[TestClass]
+public class IfCollapsibleTest
 {
-    [TestClass]
-    public class IfCollapsibleTest
-    {
-        [TestMethod]
-        public void IfCollapsible_CS() =>
-            new VerifierBuilder<CS.IfCollapsible>().AddPaths("IfCollapsible.cs").Verify();
+    [TestMethod]
+    public void IfCollapsible_CS() =>
+        new VerifierBuilder<CS.IfCollapsible>().AddPaths("IfCollapsible.cs").Verify();
 
-        [TestMethod]
-        public void IfCollapsible_VB() =>
-            new VerifierBuilder<VB.IfCollapsible>().AddPaths("IfCollapsible.vb").Verify();
-    }
+    [TestMethod]
+    public void IfCollapsible_VB() =>
+        new VerifierBuilder<VB.IfCollapsible>().AddPaths("IfCollapsible.vb").Verify();
 }
diff --git a/analyzers/tests/SonarAnalyzer.Test/TestCases/IfCollapsible.cs b/analyzers/tests/SonarAnalyzer.Test/TestCases/IfCollapsible.cs
@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Globalization;
 using System.IO;
 using System.Linq;
 using System.Text;
@@ -65,4 +66,38 @@ public void Test(bool cond1, bool cond2, bool cond3)
             }
         }
     }
+
+    // Reproducer for https://github.com/SonarSource/sonar-dotnet/issues/9221
+    public class Repro_9221
+    {
+        public DateTime? ThisWorks()
+        {
+            dynamic anything = "2024-05-13";
+            string notDynamic = "2024-05-13";
+
+            if (anything is string) // Secondary
+                if (DateTime.TryParseExact(anything, "yyyy-MM-dd", CultureInfo.InvariantCulture, DateTimeStyles.None, out DateTime dt)) // Noncompliant FP
+                    return dt;
+
+            if (notDynamic != null) // Secondary
+                if (notDynamic == "something" && anything is string) // Noncompliant FP
+                    return null;
+
+            if (notDynamic != null) // Secondary
+                if (notDynamic == "something") // Noncompliant
+                    return null;
+
+            return null;
+        }
+
+        public DateTime? ThisWontWork()
+        {
+            dynamic anything = "2024-04-29";
+
+            if (anything is string && DateTime.TryParseExact(anything, "yyyy-MM-dd", CultureInfo.InvariantCulture, DateTimeStyles.None, out DateTime dt))
+                return dt; // Error [CS0165]
+
+            return null;
+        }
+    }
 }