Add Repro for issue #6449

SonarSource · Jan 12, 2023 · 559df68 · 559df68
1 parent 202b97a
commit 559df68
Showing 1 changed file with 15 additions and 0 deletions.
diff --git a/...yzers/tests/SonarAnalyzer.UnitTest/TestCases/ParameterValidationInAsyncShouldBeWrapped.cs b/...yzers/tests/SonarAnalyzer.UnitTest/TestCases/ParameterValidationInAsyncShouldBeWrapped.cs
@@ -1,5 +1,6 @@
 using System;
 using System.IO;
+using System.Linq;
 using System.Threading.Tasks;
 
 namespace Tests.Diagnostics
@@ -55,6 +56,20 @@ private static ArgumentNullException GetArgumentExpression(string name)
 
     public class ValidCases
     {
+        // https://github.com/SonarSource/sonar-dotnet/issues/6449
+        public class Repro_6449
+        {
+            public Task<int[]> CheckAsync() => Task.FromResult(new int[] { 1 });
+            public Task<int> Check2Async() => Task.FromResult(1);
+
+            public async Task HasS4457Async(int request) // Noncompliant, FP
+            {
+                var identifierType = (await CheckAsync()).FirstOrDefault(x => x == request);
+                if (identifierType == 0)
+                    throw new ArgumentException("message"); // Secondary
+            }
+        }
+
         public static Task FooAsync(string something)
         {
             if (something == null) { throw new ArgumentNullException(nameof(something)); }