Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update S2255: Remove Cookie reading from Rule S2255 #2384

Closed
nicolas-harraudeau-sonarsource opened this issue Apr 16, 2019 · 0 comments · Fixed by #2400
Closed

Update S2255: Remove Cookie reading from Rule S2255 #2384

nicolas-harraudeau-sonarsource opened this issue Apr 16, 2019 · 0 comments · Fixed by #2400
Assignees
@christophe-zurn-sonarsource
Labels
Type: Improvement Making existing code better.
Projects
Best Kanban
Milestone
7.14

Comments

@nicolas-harraudeau-sonarsource
Copy link

In order to make security hotspot rules more useful to developers, we are refocusing them on issues which are not already covered by our taint analysis engine. Thus we now remove cookie reading from Rule S2255.

For C#, this was added recently by #1842. Note that the PR cannot be fully reverted as the rule was new for SonarVB.net.
@andrei-epure-sonarsource andrei-epure-sonarsource added this to the 7.14 milestone Apr 17, 2019
@christophe-zurn-sonarsource christophe-zurn-sonarsource moved this from To do to In progress in Best Kanban Apr 25, 2019
Merged
@christophe-zurn-sonarsource christophe-zurn-sonarsource moved this from In progress to Review in progress in Best Kanban May 1, 2019
@andrei-epure-sonarsource andrei-epure-sonarsource moved this from Review in progress to In progress in Best Kanban May 1, 2019
@christophe-zurn-sonarsource christophe-zurn-sonarsource moved this from In progress to Review in progress in Best Kanban May 1, 2019
@andrei-epure-sonarsource andrei-epure-sonarsource moved this from Review in progress to Reviewer approved in Best Kanban May 1, 2019
Best Kanban automation moved this from Reviewer approved to Done May 1, 2019
andrei-epure-sonarsource pushed a commit that referenced this issue May 1, 2019
@christophe-zurn-sonarsource @andrei-epure-sonarsource
Fix #2384: Update Rule S2255 (remove cookie reading) (#2400)
5cc3f95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophe-zurn-sonarsource christophe-zurn-sonarsource

Labels
Type: Improvement Making existing code better.
Projects
Best Kanban
  
Done
Milestone
7.14
Development

Successfully merging a pull request may close this issue.

Fix #2384: Update Rule S2255 (remove cookie reading) SonarSource/sonar-dotnet
3 participants
@christophe-zurn-sonarsource @andrei-epure-sonarsource @nicolas-harraudeau-sonarsource