Fix S1226 FP: Parameters wrongly considered as unread before reassignment

[saciervo]

Description

According to RSPEC-1226

parameters should be [...] at least read before reassignment

Is null-checking or passing a parameter to a method like string.IsNullOrWhiteSpace(text) not reading the parameter?

Repro steps

public class Class1
{
    public void Foo(string text)
    {
        if (string.IsNullOrWhiteSpace(text))
        {
            text = "(empty)";
        }

        Bar(text);
    }

    private void Bar(string text)
    {
        // Do something
    }
}

Expected behavior

The variable text has been used before it was assigned. So this code should be compliant.

Actual behavior

The code is marked as non-compliant.

Known workarounds

Use the parameter to assign a local variable.

Related information

• SonarC# Version: 7.15
• Visual Studio Version: 16.2.0 (VS2019)