Fields and properties with different string values in them should not be marked as duplicate

[andrei-epure-sonarsource]

Description

With a base class

    internal abstract class CodeGenBase
    {
        protected abstract string GenericTypeStart { get; }
        protected abstract string GenericTypeEnd { get; }
    }

and two sub classes

    class CodeGenCs : CodeGenBase
    {
        Type[] types = { typeof(int), typeof(uint), typeof(string) };

        string[] names = { "int", "uint", "string" };

        protected override string GenericTypeStart => "<";

        protected override string GenericTypeEnd => ">";
        // ... some duplicated code below to make sure class has many lines
    }

and

   class CodeGenVb : CodeGenBase
    {
        Type[] types = { typeof(int), typeof(uint), typeof(string) };

        string[] names = { "Integer", "UInteger", "String" };

        protected override string GenericTypeStart => "(Of";

        protected override string GenericTypeEnd => ")";
        // ... some duplicated code below to make sure class has many lines
    }

The lines with names, GenericTypeStart and GenericTypeEnd are marked as duplicates, even if the string values they contain are different.

See this community thread for details

Expected behavior

Lines that are not duplicated should be considered as such.

Related information

• SonarC# Version 7.16

[pavel-mikula-sonarsource]

@andrei-epure-sonarsource Can you please add labels since it's confirmed? I'm not sure how/where code duplication for SQ is generated.

[andrei-epure-sonarsource]

I guess it's the dotnet analyzers which compute the metrics for syntax nodes and in this case it probably doesn't check the content of the string values.

it is confirmed, I remember I tried to do a repro