Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S1479 FP: Single line case clause should be ignored #3050

Closed
andrei-epure-sonarsource opened this issue Jan 16, 2020 · 1 comment · Fixed by #9396
Closed

Fix S1479 FP: Single line case clause should be ignored #3050

andrei-epure-sonarsource opened this issue Jan 16, 2020 · 1 comment · Fixed by #9396
Assignees
@sebastien-marichal
Labels
Area: C# C# rules related issues. Type: False Positive Rule IS triggered when it shouldn't be.
Milestone
9.28

Comments

@andrei-epure-sonarsource
Copy link
Contributor

andrei-epure-sonarsource commented Jan 16, 2020 •
edited by antonioaversa
Loading

Description

See the suggested updates on our forum regarding S1479
Closed
@pavel-mikula-sonarsource pavel-mikula-sonarsource added Type: False Positive Rule IS triggered when it shouldn't be. and removed Type: Improvement labels May 29, 2024
@sebastien-marichal sebastien-marichal self-assigned this Jun 4, 2024
@sebastien-marichal sebastien-marichal changed the title Update S1479 to be “switch” statements with many “case” clauses should have only one statement Fix S1479 FP: Single line case clause should be ignored Jun 4, 2024
@sebastien-marichal sebastien-marichal mentioned this issue Jun 4, 2024
Merged
@antonioaversa antonioaversa mentioned this issue Jun 4, 2024
Merged
4 tasks
@sebastien-marichal
Copy link
Contributor

Implementation is done in #9396.
However, the implementation triggered a lot of discussion regarding the RSPEC update.
The controversial part is about the data mapping scenario which is too specific for this rule.

@mary-georgiou-sonarsource mary-georgiou-sonarsource added this to the 9.28 milestone Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastien-marichal sebastien-marichal

Labels
Area: C# C# rules related issues. Type: False Positive Rule IS triggered when it shouldn't be.
Projects
None yet
Milestone
9.28
Development

Successfully merging a pull request may close this issue.

Fix S1479 FP: Single line case clause should be ignored SonarSource/sonar-dotnet
7 participants
@Tim-Pohlmann @andrei-epure-sonarsource @pavel-mikula-sonarsource @CristianAmbrosini @mary-georgiou-sonarsource @martin-strecker-sonarsource @sebastien-marichal