Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S2115 FN: Support multi-line string interpolation inside a raw string literal #6293

Closed
gregory-paidis-sonarsource opened this issue Nov 7, 2022 · 0 comments · Fixed by #6359
Closed

Fix S2115 FN: Support multi-line string interpolation inside a raw string literal #6293

gregory-paidis-sonarsource opened this issue Nov 7, 2022 · 0 comments · Fixed by #6359
Assignees
@cristian-ambrosini-sonarsource
Labels
Type: False Negative Rule is NOT triggered when it should be.
Projects
Best Kanban Backlog
Milestone
8.49

Comments

@gregory-paidis-sonarsource
Copy link
Contributor

Description

FN for S2115 (DatabasePasswordsShouldBeSecure).

Using C#11 multi-line string interpolation inside a raw string literal, the rule is not raising an issue.

Repro steps

string[] test = new string[] { "FirstTest", "SecondTest" };
optionsBuilder.UseSqlServer($$"""Server={{test
    [0]}};Database=myDataBase;User Id=myUsername;Password="""); // FN

Expected behavior

The rule should raise an issue.

Actual behavior

The rule does not raise an issue.
@gregory-paidis-sonarsource gregory-paidis-sonarsource added Type: False Negative Rule is NOT triggered when it should be. Area: C# 11 labels Nov 7, 2022
@github-actions github-actions bot added this to False Negative in Backlog Nov 7, 2022
@csaba-sagi-sonarsource csaba-sagi-sonarsource added this to the 8.49 milestone Nov 7, 2022
@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource moved this from To do to In progress in Best Kanban Nov 14, 2022
Merged
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Nov 14, 2022
@github-actions github-actions bot moved this from Review in progress to In progress in Best Kanban Nov 14, 2022
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Nov 14, 2022
@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban Nov 14, 2022
@gregory-paidis-sonarsource gregory-paidis-sonarsource moved this from Review approved to Review in progress in Best Kanban Nov 15, 2022
@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban Nov 15, 2022
Backlog automation moved this from False Negative to Done Nov 15, 2022
Best Kanban automation moved this from Review approved to Validate Peach Nov 15, 2022
@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource moved this from Validate Peach to Done in Best Kanban Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource

Labels
Type: False Negative Rule is NOT triggered when it should be.
Projects
Best Kanban
  
Done
Backlog
  
Done
Milestone
8.49
3 participants
@csaba-sagi-sonarsource @cristian-ambrosini-sonarsource @gregory-paidis-sonarsource