Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S2115 FN: Support multi-line string interpolation inside a raw string literal #6359

Merged
merged 3 commits into from
Nov 15, 2022
Merged

Fix S2115 FN: Support multi-line string interpolation inside a raw string literal #6359

merged 3 commits into from
Nov 15, 2022

Conversation

cristian-ambrosini-sonarsource
Copy link
Contributor

Fixes #6293

@gregory-paidis-sonarsource
Copy link
Contributor

I added a minor change. I also see a hotspot issue raised by sonarcloud on line 169.

Apart from that, looks good to me!

csaba-sagi-sonarsource
csaba-sagi-sonarsource approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@csaba-sagi-sonarsource csaba-sagi-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarcloud
Copy link

sonarcloud bot commented Nov 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Nov 15, 2022 •
edited

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource deleted the cristian/S2115-FN-fix branch November 15, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csaba-sagi-sonarsource csaba-sagi-sonarsource csaba-sagi-sonarsource approved these changes

@gregory-paidis-sonarsource gregory-paidis-sonarsource gregory-paidis-sonarsource approved these changes

Assignees

@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix S2115 FN: Support multi-line string interpolation inside a raw string literal
4 participants
@cristian-ambrosini-sonarsource @gregory-paidis-sonarsource @csaba-sagi-sonarsource @CristianAmbrosini