Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UtilityAnalyzer: EnableConcurrentExecution #6674

Open
martin-strecker-sonarsource opened this issue Jan 25, 2023 · 1 comment · May be fixed by #8459
Open

UtilityAnalyzer: EnableConcurrentExecution #6674

martin-strecker-sonarsource opened this issue Jan 25, 2023 · 1 comment · May be fixed by #8459
Labels
Area: C# C# rules related issues. Area: VB.NET VB.NET rules related issues. Type: Performance It takes too long.

Comments

@martin-strecker-sonarsource
Copy link
Contributor

We should EnableConcurrentExecution for the UtilityAnalyzer. See also
#6576 (comment)

Reasoning:

The file writes are protected by a lock already and the collection of the messages can be easily made thread-safe by using a concurrent stack instead of the list. The UtilityAnalyzer contribute a lot to the overall performance and running them concurrently next to the others should help with overall throughput.

Blocked by #6576
@martin-strecker-sonarsource martin-strecker-sonarsource added Area: VB.NET VB.NET rules related issues. Area: C# C# rules related issues. Type: Performance It takes too long. labels Jan 25, 2023
Merged
@pavel-mikula-sonarsource
Copy link
Contributor

As part of this card, we need to measure the impact before merging it.

Merged
Closed
4 tasks
@csaba-sagi-sonarsource csaba-sagi-sonarsource moved this from To do to In progress in Best Kanban May 19, 2023
@csaba-sagi-sonarsource csaba-sagi-sonarsource removed their assignment May 19, 2023
@csaba-sagi-sonarsource csaba-sagi-sonarsource moved this from In progress to To do in Best Kanban May 19, 2023
@csaba-sagi-sonarsource csaba-sagi-sonarsource moved this from To do to In progress in Best Kanban May 19, 2023
Closed
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban May 22, 2023
@costin-zaharia-sonarsource costin-zaharia-sonarsource moved this from Review in progress to In progress in Best Kanban May 24, 2023
@csaba-sagi-sonarsource csaba-sagi-sonarsource removed this from In progress in Best Kanban May 24, 2023
Closed
Closed
@csaba-sagi-sonarsource csaba-sagi-sonarsource removed their assignment Aug 2, 2023
@martin-strecker-sonarsource martin-strecker-sonarsource linked a pull request Dec 11, 2023 that will close this issue
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: C# C# rules related issues. Area: VB.NET VB.NET rules related issues. Type: Performance It takes too long.
Projects
None yet
Milestone
No milestone
4 participants
@costin-zaharia-sonarsource @pavel-mikula-sonarsource @csaba-sagi-sonarsource @martin-strecker-sonarsource