Make UtilityAnalyzerBase stateless by removing properties

[martin-strecker-sonarsource]

Pre-condition for #6674

Analyzer should be stateless. This PR removes the properties from UtilityAnalyzerBase and captures them in RegisterCompilationStartAction per compilation.

After this change, EnableConcurrentExecution can be set to true (and also var treeMessages = new List<TMessage>(); needs to be changed to var treeMessages = new ConcurrentStack<TMessage>(); of course).

[martin-strecker-sonarsource]

Like with the OutPath property, the mutable state is the root cause that prevents ConcurrentExecution (to be fair: ConcurrentExecution would also work without this change, but it is tough to see why that is the case. With this change, it is evident that it works, and it is no longer possible to break it).

The PR moves the state into its own type, which is now captured in RegisterCompilationStartAction for the compilation. The new Parameters struct is readonly now and passed to all methods that need it to make decisions.

[andrei-epure-sonarsource]

This is slowly getting out of sync.

I suggest to close this and link it to the issue so the ideas can be reused once it will be actively worked on.

[gregory-paidis-sonarsource]

There is also ConcurrentQueue and ConcurrentBag, and the implementation yields different performance based on the scenario you are targeting. For example, one of these collections might be faster in the context of many-threads-writing and one-thread-reading, but another must be faster if you have a lot of thread-writing/reading contextion. So I think we should:

• Understand what kind of concurrency this analyzer needs
• Benchmark the collections in that setting (e.g. make a testbed were the threads are writing rapid-fire, if that's what we expect to happen here)
• Pick the best one

Concurrent collections: click here

[mary-georgiou-sonarsource]

We need to open a cleanup issue for this PR because the CreateMessage method in the base UtilityAnalyzer class is getting the parameters as input but they are only used by one derived class.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

[csaba-sagi-sonarsource]

LGTM!